This is the mail archive of the mailing list for the GCC project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Patch ping

Jan Hubicka <> writes:

>> Zdenek Dvorak <> writes:
>> > Hello,
>> >
>> > could someone please review
>> >
>> >
>> >
>> > I would like to get this in, since it uses value profiling, and I feel
>> > wrong about having a piece of unused and therefore untested code in gcc.
>> > And of course, it also makes a nice improvement in benchmarks.
>> I don't see anything wrong with the code, but I would like someone
>> more familiar with the profiler to comment.  Since this was submitted
>> well before the deadline and only affects a non-default optimization
>> mode, I think it can go in now if (say) Nathan Sidwell thinks the code
>> is sound.
> The actual interface to profiling code came in earlier with separate
> patch.  This patch has no consequences to the profiling, just uses the
> interface we agreed on earlier, so I would say that there is no problem
> from profiler side. (this is also why I don't feel this belong to area I
> can approve as gcov maintainer)

Zack, since the profiler code is ok, I interpret your message that
this is approved.  Correct?

 Andreas Jaeger,,
  SuSE Linux AG, Deutschherrnstr. 15-19, 90429 Nürnberg, Germany
   GPG fingerprint = 93A3 365E CE47 B889 DF7F  FED1 389A 563C C272 A126

Attachment: pgp00000.pgp
Description: PGP signature

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]