This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Patch ping
- From: "Zack Weinberg" <zack at codesourcery dot com>
- To: Zdenek Dvorak <rakdver at atrey dot karlin dot mff dot cuni dot cz>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Sun, 19 Oct 2003 10:37:28 -0700
- Subject: Re: Patch ping
- References: <20031019101617.GA15107@atrey.karlin.mff.cuni.cz>
Zdenek Dvorak <rakdver@atrey.karlin.mff.cuni.cz> writes:
> Hello,
>
> could someone please review
>
> http://gcc.gnu.org/ml/gcc-patches/2003-07/msg02991.html?
>
> I would like to get this in, since it uses value profiling, and I feel
> wrong about having a piece of unused and therefore untested code in gcc.
> And of course, it also makes a nice improvement in benchmarks.
I don't see anything wrong with the code, but I would like someone
more familiar with the profiler to comment. Since this was submitted
well before the deadline and only affects a non-default optimization
mode, I think it can go in now if (say) Nathan Sidwell thinks the code
is sound.
You have some English grammar issues with the documentation.
zw