This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Yet another tree dumper

Gabriel Dos Reis wrote:

Per Bothner <per@bothner.com> writes:

| A suggestion:
| | Check in the new tree-dumper, but into the print-tree.c
| like this:
| | #define USE_NEW_DUMPER 1
| #ifdef NEW_DUMPER

we've gone a long way in moving toward

  if (SOME_FEATURE)
    // ..

instead of

#ifdef SOME_FEATURE. 

#ifdef is better in this case.
(1) it's intended to be temporary.  We're not testing a
feature in the usual sense; we're selecting between two
alternative implementations of the same utility.
(2) if (SOME_FEATURE) cannot conditionalize
function definitions, as probably needed in this case.
--
	--Per Bothner
per@bothner.com   http://per.bothner.com/


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]