This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Constant fold <string.h> library functions
- From: law at redhat dot com
- To: Roger Sayle <roger at eyesopen dot com>
- Cc: gcc-patches at gcc dot gnu dot org, Richard Henderson <rth at redhat dot com>
- Date: Fri, 17 Oct 2003 12:46:45 -0600
- Subject: Re: [PATCH] Constant fold <string.h> library functions
- Reply-to: law at redhat dot com
In message <Pine.LNX.4.44.0310171141530.3802-100000@www.eyesopen.com>, Roger Sa
yle writes:
>Good god, no. I've only just taken a look, but its one of the most
>depressing things I've come across in the GCC sources recently.
Now imagine actually having to write that stuff! :(
>To use a random example, I took a quick peek at simplify_builtin_strcmp
>and it contains both the invalid strcmp -> memcmp optimization, see
>http://gcc.gnu.org/ml/gcc-patches/2003-10/msg00188.html,
Yes, that's a fairly recent thing that we're going to have to pick up.
> but also and
>more worrying for the tree-ssa branch, unlike mainline its destructive
>modifying trees in place, using chainon on the original argument list.
On tree-ssa the trees are unshared, which ought to make this safe. If
it's really that offensive it wouldn't be terrible to generate a new
argument list.
jeff