Re: Unreviewed^3 Patches

[David Daney <ddaney at avtrex dot com>]

Rainer Orth wrote:

> The following patches have remained unreviewed for some time, despite two
> reminders.
>
> * 3.4 PATCH: Pass multilib flags to libobjc
>
> 	http://gcc.gnu.org/ml/gcc-patches/2003-09/msg01115.html
>
>  Though trivial, this requires both a build (for config-ml.in) and
>  Objective-C (for libobjc/Makefile.in) maintainer to review.
>
> * 3.4 PATCH: Provide target hook for special handling of collect2 flags
>
> 	http://gcc.gnu.org/ml/gcc-patches/2003-09/msg01125.html
>
>  Again trivial, but requires a global-write-privs maintainer.  The
>  alternative proposed in my own follow-up
>
> 	http://gcc.gnu.org/ml/gcc-patches/2003-09/msg01524.html
>
>  may be better, though.
>
> * 3.4 PATCH: IRIX 6 configuration cleanup and O32 ABI integration
>
> 	http://gcc.gnu.org/ml/gcc-patches/2003-09/msg02075.html
>
>  This is now the strictly mips-only part of the IRIX 6 O32 integration.
>  The other two are prerequisites for this one and need to go in first.
>
> Thanks.
> 	Rainer
>
> -----------------------------------------------------------------------------
> Rainer Orth, Faculty of Technology, Bielefeld University
>  
I think as part of this you did:

   * config/mips/linux.h (FUNCTION_NAME_ALREADY_DECLARED): Define as 1.

Which causes me these warnings when configured as target=mipsisa32-linux:

<...>
gcc -c   -g -O2 -DIN_GCC -DCROSS_COMPILE  -W -Wall -Wwrite-strings 
-Wstrict-prototypes -Wmissing-prototypes -pedantic -Wno-long-long  
-fno-common   -DHAVE_CONFIG_H    -I. -Icp -I../../gcccvsw/gcc/gcc 
-I../../gcccvsw/gcc/gcc/cp -I../../gcccvsw/gcc/gcc/../include  
../../gcccvsw/gcc/gcc/cp/except.c -o cp/except.o
In file included from tm.h:16,
                from ../../gcccvsw/gcc/gcc/cp/except.c:29:
../../gcccvsw/gcc/gcc/config/mips/linux.h:174:1: warning: 
"FUNCTION_NAME_ALREADY_DECLARED" redefined
In file included from tm.h:15,
                from ../../gcccvsw/gcc/gcc/cp/except.c:29:
../../gcccvsw/gcc/gcc/config/mips/mips.h:3294:1: warning: this is the 
location of the previous definition
<...>


I am also getting this again:
<...>
/home/daney/mipsel-gcccvs/gcc/xgcc -B/home/daney/mipsel-gcccvs/gcc/ 
-B/home/testcvs//mipsisa32el-linux/bin/ 
-B/home/testcvs//mipsisa32el-linux/lib/ -isystem 
/home/testcvs//mipsisa32el-linux/include -isystem 
/home/testcvs//mipsisa32el-linux/sys-include -DHAVE_CONFIG_H -I. 
-I../../../gcccvsw/gcc/libffi -I. -I../../../gcccvsw/gcc/libffi/include 
-Iinclude -I../../../gcccvsw/gcc/libffi/src -O2 -g -O2 -Wall -g 
-fexceptions -O2 -g -O2 -c ../../../gcccvsw/gcc/libffi/src/debug.c  
-fPIC -DPIC -o src/.libs/debug.o
In file included from include/ffi.h:156,
                from ../../../gcccvsw/gcc/libffi/src/debug.c:24:
../../../gcccvsw/gcc/libffi/include/ffi_mips.h:39: error: parse error 
before '--' token
In file included from ../../../gcccvsw/gcc/libffi/src/debug.c:24:
<...>

Which was broken and fixed.  But at some point re-broke.

David Daney.