This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [RFA] CONSTANT_RTX_P patch to builtins.c
- From: graham dot stott at btinternet dot com
- To: echristo at redhat dot com, gcc-patches at gcc dot gnu dot org
- Cc: roger at eyesopen dot com
- Date: Thu, 16 Oct 2003 16:51:25 +0100 (BST)
- Subject: Re: [RFA] CONSTANT_RTX_P patch to builtins.c
Hi Eric,
Further to my previous comments
> -/* Instantiate all remaining CONSTANT_P_RTX nodes. */
> /* Helper function to determine CONSTANT_P_RTX called through
> for_each_rtx. Returns true iff the rtl is CONSTANT_P_RTX. */
>
> static int
> is_constant_p_rtx (rtx *rtl, void *data)
> {
> int constant = (int)&data;
This needs to be "int *constant = data"
>
> if (*rtl == NULL_RTX)
> return 0;
>
> if (GET_CODE (*rtl) == CONSTANT_P_RTX)
> {
> constant = CONSTANT_P (XEXP (*rtl, 0));
and this needs to be "*constant = ..."
> return 1;
> }
>
> return 0;
> }
>
> /* Resolve all remaining CONSTANT_P_RTX nodes. */