This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Patch: performing decl operation on type


On Tuesday, October 14, 2003, at 07:06 PM, Robert Bowdidge wrote:
This code also must never be run, for the type check in SET_DECL_RTL would have put out an assertion if so.

I'd like to remove this code because it's (1) dead code

Ok, I'm confused, do you want to remove the entire if () { } block as we know it is dead, or just fix it to be correct, even though it is dead and will remain that way? The below, I'd call that just fixing the dead code.


I think I'd lean towards just removing the entire if (...) { ... } block on the grounds that it would cause checking failures during compiles if anyone exercised it during development.

Ok to submit?

It's already been submitted. Maybe you meant commit?


-      SET_DECL_RTL (TREE_TYPE (decl), NULL_RTX);
+      SET_DECL_RTL (decl, NULL_RTX);


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]