This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] - Use of powerpc 64bit instructions in 32bit ABI

> Is there a better way to do this computation?

I don't think you should be relying on move_block_to_regs at all.
You should be returning a PARALLEL from function_arg in this case.

Similar arguments apply to other instances of 
UNITS_PER_REGISTER_ARGUMENT in your patch, at least call related.

EVERY instance of GET_MODE_BITSIZE(SImode) that you added to replace
BITS_PER_WORD is wrong.   Unconditionally.  SImode is 128 bits wide
on c4x.

You can't possibly submit this as 5000 line patch either.  You need
to split this up into lots of smaller pieces.  Each patch should do
exactly one thing.


r~
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]