This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
[v3] Fix libstdc++/11460
- From: Paolo Carlini <pcarlini at unitus dot it>
- To: gcc-patches at gcc dot gnu dot org
- Date: Sun, 12 Oct 2003 22:05:09 +0200
- Subject: [v3] Fix libstdc++/11460
Hi,
tested x86-linux, committed.
Paolo.
/////////
2003-10-12 Petur Runolfsson <peturr02@ru.is>
Paolo Carlini <pcarlini@unitus.it>
PR libstdc++/11460
* src/strstream.cc (pbackfail): Fix to use to_int_type.
* testsuite/backward/11460.cc: New, from the PR.
diff -urN libstdc++-v3-orig/src/strstream.cc libstdc++-v3/src/strstream.cc
--- libstdc++-v3-orig/src/strstream.cc 2003-03-05 23:24:56.000000000 +0100
+++ libstdc++-v3/src/strstream.cc 2003-10-12 21:39:44.000000000 +0200
@@ -194,7 +194,7 @@
gbump(-1);
return _Traits::not_eof(c);
}
- else if (c == static_cast<int_type>(gptr()[-1]))
+ else if (c == _Traits::to_int_type(gptr()[-1]))
{ // KLUDGE
gbump(-1);
return c;
diff -urN libstdc++-v3-orig/testsuite/backward/11460.cc libstdc++-v3/testsuite/backward/11460.cc
--- libstdc++-v3-orig/testsuite/backward/11460.cc 1970-01-01 01:00:00.000000000 +0100
+++ libstdc++-v3/testsuite/backward/11460.cc 2003-10-12 21:44:11.000000000 +0200
@@ -0,0 +1,73 @@
+// Copyright (C) 2003 Free Software Foundation, Inc.
+//
+// This file is part of the GNU ISO C++ Library. This library is free
+// software; you can redistribute it and/or modify it under the
+// terms of the GNU General Public License as published by the
+// Free Software Foundation; either version 2, or (at your option)
+// any later version.
+
+// This library is distributed in the hope that it will be useful,
+// but WITHOUT ANY WARRANTY; without even the implied warranty of
+// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+// GNU General Public License for more details.
+
+// You should have received a copy of the GNU General Public License along
+// with this library; see the file COPYING. If not, write to the Free
+// Software Foundation, 59 Temple Place - Suite 330, Boston, MA 02111-1307,
+// USA.
+
+#include <strstream>
+#include <testsuite_hooks.h>
+
+// { dg-options "-Wno-deprecated" }
+
+class Buf : public std::strstreambuf
+{
+public:
+ Buf(const char* p, std::streamsize n)
+ : std::strstreambuf(p, n)
+ { }
+
+ int_type pub_pbackfail(int_type c = traits_type::eof())
+ {
+ return pbackfail(c);
+ }
+};
+
+// libstdc++/11460
+void test01()
+{
+ bool test __attribute__((unused)) = true;
+
+ typedef std::strstreambuf::traits_type Traits;
+ const char str[] = "a\xff";
+
+ Buf buf(str, 2);
+
+ Traits::int_type a = Traits::to_int_type('a');
+ VERIFY( buf.sbumpc() == a );
+ VERIFY( buf.sungetc() == a );
+ VERIFY( buf.sbumpc() == a );
+ VERIFY( buf.sputbackc('a') == a );
+ VERIFY( buf.sbumpc() == a );
+ VERIFY( buf.pub_pbackfail() != Traits::eof() );
+ VERIFY( buf.sbumpc() == a );
+ VERIFY( buf.pub_pbackfail(a) == a );
+ buf.sbumpc();
+
+ Traits::int_type xff = Traits::to_int_type('\xff');
+ VERIFY( buf.sbumpc() == xff );
+ VERIFY( buf.sungetc() == xff );
+ VERIFY( buf.sbumpc() == xff );
+ VERIFY( buf.sputbackc('\xff') == xff );
+ VERIFY( buf.sbumpc() == xff );
+ VERIFY( buf.pub_pbackfail() != Traits::eof() );
+ VERIFY( buf.sbumpc() == xff );
+ VERIFY( buf.pub_pbackfail(xff) == xff );
+}
+
+int main()
+{
+ test01();
+ return 0;
+}