This is the mail archive of the mailing list for the GCC project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: 3.4 PATCH: Fix libffi MIPS O32/N64 ABI handling

Daniel Jacobowitz writes:

> GNU/Linux, on the other hand, expects _MIPS_SIM_ABI32.  It'd be a
> little hard to change at this date, since the kernel and C library have
> it all over the place.

Do you know where the get the definition of that symbol?  Only from GCC's
predefines, or from <sgidefs.h> or some GNU/Linux equivalent thereof.

It seems strange that MIPS GNU/Linux depends on GCC predefining
_MIPS_SIM_ABI32 for the O32 ABI, but can easily live without the
corresponding definitions for N32/N64 (where _MIPS_SIM is only defined in
terms of _ABIN32/_ABI64).

If GCC really must continue to predefine _MIPS_SIM_ABI32 for O32, I'm
certainly fine to leave that definition for linux (just a one-line change
to config/mips/linux.h), but I think it's better for the GCC tree to be
internally consistent and use the _ABI* values throughout for all three

> Not sure if you were proposing that, just commenting.

Have you checked the actual patch?


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]