This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] AmigaOS 4 port contribution [libiberty]
Marcus Comstedt <marcus@mc.pp.se> writes:
>
> Ok, I have implemented these changes, and improved the pexecute
> implementation to pass the test suggested by Zack. What I'm going to
> do now is to subdivide the patches according to the different
> ChangeLogs so that I can repost them more quickly as I get ready with
> each subpart. Here is then the updated subpatch for libiberty.
pex-amigaos.c didn't get included in this diff.
> +#ifdef __amigaos__
> +# ifndef DIR_SEPARATOR_2
> +# define DIR_SEPARATOR_2 ':'
> +# endif
> +#endif
Here and elsewhere: only indent nested preprocessor directives one
space per level. Also, I would suggest that this go into
include/filenames.h instead of being replicated in several different
libiberty files. (It may be possible to refactor other goo from these
files into that header, but you don't have to do that.)
zw