This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: GCC build failed for native with your patch on 2003-10-06T06:15:01Z.

From: Geoff Keating <geoffk at geoffk dot org>
To: Falk Hueffner <falk dot hueffner at student dot uni-tuebingen dot de>
Cc: Andrew Pinski <pinskia at physics dot uc dot edu>, gcc-patches at gcc dot gnu dot org
Date: 06 Oct 2003 13:40:23 -0700
Subject: Re: GCC build failed for native with your patch on 2003-10-06T06:15:01Z.
References: <200310060630.h966UwGu023614@gcc-regress.apple.com><7DBBFDA4-F7C7-11D7-9ABD-000393A6D2F2@physics.uc.edu><jmad8e186l.fsf@desire.geoffk.org><87ekxqtbgs.fsf@student.uni-tuebingen.de>

Falk Hueffner <falk.hueffner@student.uni-tuebingen.de> writes:

> Geoff Keating <geoffk@geoffk.org> writes:
> 
> > This is OK, but the coding conventions say you should write it as
> > 
> > memcpy (buffer + bufferlen + 1, "$stub\"", strlen("$stub\"") + 1);
> 
> Maybe I'm missing something, but why not just write
> 
> strcpy (buffer + bufferlen + 1, "$stub\"");

That would probably be better, yes.

-- 
- Geoffrey Keating <geoffk@geoffk.org>

References:
- Re: GCC build failed for native with your patch on 2003-10-06T06:15:01Z.
  - From: Andrew Pinski
- Re: GCC build failed for native with your patch on 2003-10-06T06:15:01Z.
  - From: Geoff Keating
- Re: GCC build failed for native with your patch on 2003-10-06T06:15:01Z.
  - From: Falk Hueffner

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]