This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] AmigaOS 4 port contribution
- From: kenner at vlsi1 dot ultra dot nyu dot edu (Richard Kenner)
- To: marcus at mc dot pp dot se
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Sun, 5 Oct 03 13:21:32 EDT
- Subject: Re: [PATCH] AmigaOS 4 port contribution
Since this formality should only affect the actual comitting of the
code to the repository, I would like to offer the code for reviewing
at this point, so that it can be ready for comitting before the end of
stage2 (2003-10-15).
At a first glance, this code has numerous (nearly one per line) violations
of the coding standard.
Please note that while the changes may look very substantial, 99% are
either inside #ifdefs
Indeed the #ifdefs are a serious problem.
+#ifdef TARGET_AMIGAOS_DECL_ATTRIBUTES
We don't have this sort of target-specific coding in front ends. You need
to figure out a portable way of doing this.