Re: [PATCH] insn priority adjustments in scheduler and rs6000 port

["Vladimir N. Makarov" <vmakarov at redhat dot com>]

Dorit Naishlos wrote:

> >   If you are changing a documentation it is also reasonable to `make
> > doc' to make sure that the documentation changes are ok and then look
> > at the generated .dvi file to check how it looks.
> >
> 'make doc'?
> 'make info' followed by 'make dvi' passed ok.
>
> >  So could you send me a fixed version of the patch for the final
> > approval.
> >
> Here it is, attached and inlined.
>

There is one typo in documentation of option `sched-stalled-insns-dep'.   The rest of the patch looks ok.

The patch really improves the code according to

http://gcc.gnu.org/ml/gcc-patches/2003-10/msg00274.html

So please go ahead and commit the patch into the mainline.

Thanks for the patch.

Vlad


>
> *************** Allow speculative motion of more load in
> *** 4114,4119 ****
> --- 4117,4134 ----
>   sense when scheduling before register allocation, i.e.@: with
>   @option{-fschedule-insns} or at @option{-O2} or higher.
>
> + @item -fsched-stalled-insns=@var{n}
> + @opindex fsched-stalled-insns
> + Define how many insns (if any) can be moved prematurely from the queue
> + of stalled insns into the ready list, during the second scheduling pass.
> +
> + @item -fsched-stalled-insns-dep=@var{n}
> + @opindex fsched-stalled-insns-dep
> + Define how many insn groups (cycles) will be examined for a dependency
> + on a stalled insn that is candidate for premature removal from the queue
> + of stalled insns.  Has an effect only suring the second scheduling pass,

I think it should be `during'.


>
> + and only if @option{-fsched-stalled-insns} is used and its value is not zero.
> +
>   @item -fsched2-use-superblocks
>   @opindex fsched2-use-superblocks
>   When scheduling after register allocation, do use superblock scheduling