This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Patch approval request
- From: David Edelsohn <dje at watson dot ibm dot com>
- To: Jeff Sturm <jsturm at one-point dot com>, Roger Sayle <roger at eyesopen dot com>, "Ulrich Weigand" <weigand at i1 dot informatik dot uni-erlangen dot de>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Fri, 03 Oct 2003 13:16:19 -0400
- Subject: Re: Patch approval request
- References: <Pine.LNX.4.44.0310030956160.26917-100000@ops2.one-point.com> <Pine.LNX.4.44.0309272123060.26972-100000@www.eyesopen.com> <200309231837.h8NIbDi21591@faui1g.informatik.uni-erlangen.de> <200309231837.h8NIbDi21591@faui1g.informatik.uni-erlangen.de>
I forwarded the Solaris x86 and S/390 bootstrap failure patches to
the GCC SC and they have been approved by Mark, with a minor change
requested for the reload patch to fix S/390.
The GCC SC is discussing how to improve patch review.
David
----- Begin Forwarded Message -----
Subject: Re: Patch approval request
From: Mark Mitchell <mark@codesourcery.com>
To: David Edelsohn <dje@watson.ibm.com>
cc: GCC Steering Committee
On Fri, 2003-10-03 at 08:05, David Edelsohn wrote:
> I request approval of the following two patches to fix continuing
> bootstrap failures:
>
> Solaris x86
> http://gcc.gnu.org/ml/gcc-patches/2003-09/msg01968.html
>
> S/390
> http://gcc.gnu.org/ml/gcc-patches/2003-09/msg01589.html
These are OK, except that the second one is not coded very tidily:
+ /* Big-endian paradoxical subregs need a negative offset. */
+ if (BYTES_BIG_ENDIAN && outer_size > inner_size)
+ offset = inner_size - outer_size;
There is an assignment to offset right above here, and it would be
clearer to eliminate that and rewrite as:
int offset;
if (BYTES_BIG_ENDIAN && outer_size > inner_size)
offset = inner_size - outer_size;
else
offset = SUBREG_BYTE (x);
--
Mark Mitchell <mark@codesourcery.com>
CodeSourcery, LLC
----- End Forwarded Message -----