This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [tree-ssa] PHI_ARG_CAPACITY != block degree


On Thu, 2003-10-02 at 17:46, Zdenek Dvorak wrote:

> *************** rewrite_block (basic_block bb)
> *** 783,789 ****
>   	  tree currdef;
>   
>   	  /* Ignore PHI nodes that have already been renamed.  */
> ! 	  if (PHI_NUM_ARGS (phi) == PHI_ARG_CAPACITY (phi))
>   	    continue;
>   
Oh, bugger.  I inadvertently left this behind.  This is wrong now that
we have a proper way of detecting whether a variable needs to be
renamed.  In here we should have a test similar to that done in
tree-ssa.c:prepare_operand_for_rename.  We should be testing whether
PHI_RESULT (phi) is present in vars_to_rename.

In any case, could you add a test case where you found this to be a
problem?  I'm curious about what kinds of failures does this generate.


Thanks.  Diego.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]