This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Import John David Anglin's patch to collect2.c onto gcc 3.3branch
- From: Hans-Peter Nilsson <hp at bitrange dot com>
- To: Nick Clifton <nickc at redhat dot com>
- Cc: gcc-patches at gcc dot gnu dot org, <numerical dot simulation at web dot de>
- Date: Wed, 1 Oct 2003 11:00:01 -0400 (EDT)
- Subject: Re: Import John David Anglin's patch to collect2.c onto gcc 3.3branch
On Wed, 1 Oct 2003, Nick Clifton wrote:
Welcome back from vacation! :-)
> * Import this patch from mainline:
>
> 2003-02-01 John David Anglin <dave.anglin@nrc-cnrc.gc.ca>
>
> * collect2.c (pexecute_pid): Rename to pid.
(Should have been: "* collect2.c (pid): Rename from pexecute_pid.")
Aww. This looks like it's likely to cause "pid" to collide with
some other stuff called "pid" pulled in from a system library
together with whatever. If you really, really need to rename
it, why not initialize it to -1 so it'd not a COMMON symbol
(those that will merge with any other symbol).
> /* Holds the return value of pexecute. */
> ! int pid;
brgds, H-P