This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] PR C/12466 -Wold-style-definition incorrectly warns withellipsises
- From: "Kaveh R. Ghazi" <ghazi at caip dot rutgers dot edu>
- To: hp at bitrange dot com
- Cc: gcc-patches at gcc dot gnu dot org, kelleycook at wideopenwest dot com
- Date: Wed, 1 Oct 2003 10:18:33 -0400 (EDT)
- Subject: Re: [PATCH] PR C/12466 -Wold-style-definition incorrectly warns withellipsises
- References: <Pine.BSF.4.44.0310010101170.74165-100000@dair.pair.com>
> On Tue, 30 Sep 2003, Kelley Cook wrote:
> > gcc/testsuite:
> > * gcc.dg/Wold-style-definition-1.c: Add in 3 ellipsis
> testcases.
>
> Please create a new testcase.
> *Never add stuff to a testcase, particularly not new tests*.
> brgds, H-P
While I normally agree with this, there is a downside if this position
is taken to an extreme. It takes longer to run the testsuite if we
have gillions of tiny little files.
I think we should make a distinction between regression testcases that
(used to) crash the compiler and feature testcases that ensure a
feature, flag or optimization/transformation works properly.
In the latter case, as we modify or enhance the feature in question we
should update the existing testcase to reflect the new reality.
So here I think it's proper to modify the original testcase.
--Kaveh
--
Kaveh R. Ghazi ghazi@caip.rutgers.edu