This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] PR C/12466 (take 2)
- From: "Kelley Cook" <kelleycook at wideopenwest dot com>
- To: "Kaveh R. Ghazi" <ghazi at caip dot rutgers dot edu>, "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>
- Date: Wed, 01 Oct 2003 08:19:52 -0400
- Subject: Re: [PATCH] PR C/12466 (take 2)
On Tue, 30 Sep 2003 21:16:03 -0700, Richard Henderson wrote:
>On Tue, Sep 30, 2003 at 10:08:34PM -0400, Kelley Cook wrote:
>> * c-parse.in (parmlist_2): Mark declaration with an ellipsis as ISO C.
>> * gcc.dg/Wold-style-definition-1.c: Add in 2 ellipsis testcases.
>Ok.
Thanks for the review,
Unfortunately, there is a problem. I am getting some new regressions in
a testcase that was added by Kaveh Ghazi. These three functions now
warn about using ISO definitions when -Wtraditional is specified.
Snipped from gcc.dg/wtr-func-def-1.c (which is run with -Wtraditional)
----
/* Test that we don't warn about stdarg functions. */
f_stdarg1(const char *s, ...)
return 0;
void f_stdarg2(const char *s, ...)
return;
extern void f_stdarg3(const char *, ...);
void f_stdarg3(const char *s, ...)
return;
---
Personally, I'm inclined to think that contrary to the comment these cases
should also warn under -Wtraditional since they are in fact ISO style
function definintions and not in a system header.
My patch is fairly easy to correct if you disagree and wish to maintain the
current behavior.
How should I proceed?
Kelley Cook