Re: [patch] normalizing cris-linux clause in config.gcc?

[Hans-Peter Nilsson <hp at bitrange dot com>]

On Tue, 30 Sep 2003, Nathanael Nerode wrote:
> Could some cris-linux person test or comment on this?  :-)
>
> The functional change would be the addition of these, which are in t-linux
> and not in cris/t-linux:
>
> ># Override t-slibgcc-elf-ver to export some libgcc symbols with
> ># the symbol versions that glibc used.
> >SHLIB_MAPFILES += $(srcdir)/config/libgcc-glibc.ver
> >
> ># Use unwind-dw2-fde-glibc
> >LIB2ADDEH = $(srcdir)/unwind-dw2.c $(srcdir)/unwind-dw2-fde-glibc.c \
> >  $(srcdir)/unwind-sjlj.c $(srcdir)/gthr-gnat.c $(srcdir)/unwind-c.c
> >LIB2ADDEHDEP = unwind.inc unwind-dw2-fde.h unwind-dw2-fde.c gthr-gnat.c
>
> If these are /harmless/, they should presumably be used.

SHLIB_MAPFILES is harmful. The config/libgcc-glibc.ver uses a
glibc symbol version (GLIBC_2.0) that does not exist for CRIS,
so it should be overridden as is done for other targets.

LIB2ADDEHDEP is harmless.  The real difference in LIB2ADDEH is
that unwind-dw2-fde-glibc.c is used instead of unwind-dw2-fde.c.

> If they are /harmful/, they should perhaps be explicitly overridden in
> a cris/t-linux which is inserted after t-linux -- or perhaps things should
> should be left as is, but a comment should be inserted in config.gcc
> explaining why t-linux is omitted.

No, a better location for a comment would be in cris/t-linux.
It's already apparent in config.gcc that it's overridden, and
that's all that's needed there.

Patch not approved.  Please leave as is.  I'll check what's
needed to use unwind-dw2-fde-glibc.c.  (For different reasons
I'm using out of sync with glibc and have been using an old
version so this isn't a quickie.)

brgds, H-P