This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
3.4 PATCH: Test HAVE_GAS_SHF_MERGE value in java/class.c
- From: Rainer Orth <ro at TechFak dot Uni-Bielefeld dot DE>
- To: gcc-patches at gcc dot gnu dot org
- Cc: java-patches at gcc dot gnu dot org
- Date: Wed, 24 Sep 2003 03:24:47 +0200 (MEST)
- Subject: 3.4 PATCH: Test HAVE_GAS_SHF_MERGE value in java/class.c
I've just noticed another fallout from my HAVE_GAS_SHF_MERGE patch:
java/class.c tested for this with #ifdef, which worked before, but broke
libjava bootstrap on Solaris 8/SPARC with the native as because we got
section declarations like this:
.section .rodata.jutf8.22,@progbits,...
(don't recall the exact details since I've since removed the tree). Sun as
doesn't understand this syntax and bails out.
I'm currently testing this patch, will commit as obvious once bootstrap
finishes (probably not before noon today).
Sorry for the breakage, this didn't get caught during my IRIX 6 bootstraps
since libjava is disabled by default (and I intend to test it with my patch
set separately once the basic patch is sound for the other languages).
Rainer
-----------------------------------------------------------------------------
Rainer Orth, Faculty of Technology, Bielefeld University
Wed Sep 24 00:24:41 2003 Rainer Orth <ro@TechFak.Uni-Bielefeld.DE>
* class.c (build_utf8_ref): Test for HAVE_GAS_SHF_MERGE value.
Index: gcc/java/class.c
===================================================================
RCS file: /cvs/gcc/gcc/gcc/java/class.c,v
retrieving revision 1.168
diff -u -p -b -r1.168 class.c
--- gcc/java/class.c 22 Sep 2003 05:09:31 -0000 1.168
+++ gcc/java/class.c 24 Sep 2003 01:21:34 -0000
@@ -779,7 +779,8 @@ build_utf8_ref (tree name)
TREE_READONLY (decl) = 1;
TREE_THIS_VOLATILE (decl) = 0;
DECL_INITIAL (decl) = cinit;
-#ifdef HAVE_GAS_SHF_MERGE
+
+ if (HAVE_GAS_SHF_MERGE)
{
int decl_size;
/* Ensure decl_size is a multiple of utf8const_type's alignment. */
@@ -795,7 +796,7 @@ build_utf8_ref (tree name)
DECL_SECTION_NAME (decl) = build_string (strlen (buf), buf);
}
}
-#endif
+
TREE_CHAIN (decl) = utf8_decl_list;
layout_decl (decl, 0);
pushdecl (decl);