This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: patch to convert input character set to source character set
Neil Booth <neil@daikokuya.co.uk> writes:
> Zack Weinberg wrote:-
>
>> >> /* The first 256 code points of ISO 8859.1 have the same numeric
>> >> values as the first 256 code points of Unicode, therefore the
>> >> incoming ISO 8859.1 character can be passed directly to
>> >> one_cppchar_to_utf8 (which expects a Unicode value). */
>> >
>> > I'm OK with it.
>>
>> You don't see anything wrong with the buffer handling in
>> _cpp_clean_line? I was nervous about that.
>
> Sorry, I didn't look hard initially, I was put off by the claim that
> you'd reviewed it.
I reviewed it to the extent I was able, but you know that area of the
code much better than me.
zw