On Tue, 23 Sep 2003, Chandra Chavva wrote:
I have attached the patch which converters the input character set to
source character set, UTF-8 or UTF-EDCDIC depending on basic execution
character set. Also introduced new option --input-character= to specify
the default character set of the source file. The input character set is
set to "ISO-8859-1" by default.
Zack has already approved this patch.
The patch lacks documentation and testcases. You are expected to ensure
that patches follow the minimum requirements before you submit them for
review and reviewers should be able to presume that you have done so.
Of course the documentation in this case should note the default of
ISO-8859-1 is only temporary and in future other methods may be used to
determine character sets with locale as default (as required by POSIX; see
bug 3744). But perhaps your patch does fix bug 11439?