This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [m68k] Restore some original predefines and cleanup m68k target flags
On Fri, Sep 19, 2003 at 06:21:48PM +0200, Bernardo Innocenti wrote:
> Gunther Nikl wrote:
> >
> > Are you sure that TARGET_RTD wasn't functional?
>
> Well, I made a quick search for TARGET_RTD and MASK_RTD and
> they weren't used for anything besides RETURN_POPS_ARGS.
> I guess this couldn't work without additional support in
> function epilogue generation.
>
> Now I did a closer inspection and noticed that m68k.md actually
> outputs RTD when current_function_pops_args is non-zero. RTD is
> also emitted in m68k_output_function_epilogue(), so it actually
> _could_ work.
>
> Does anyone want to keep that functionality? Was it used by anyone?
I believe that you cannot remove a feature without deprecating it first.
This is very bad practice.
> Do you mean something like this?
>
> if (TARGET_68881 && (TARGET_DEFAULT & MASK_68881))
> builtin_define ("__HAVE_68881__");
Yes, with the TARGET_DEFAULT test first. But I suppose that doesn't really
matter. If such a test is added then one would need an additional check to
set the define and I don't have a suggestion for that.
Gunther