This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] for PR12223

From: Zdenek Dvorak <rakdver at atrey dot karlin dot mff dot cuni dot cz>
To: Jason Merrill <jason at redhat dot com>
Cc: gcc-patches at gcc dot gnu dot org, schwab at suse dot de,Mark Mitchell <mark at codesourcery dot com>, Andreas Jaeger <aj at suse dot de>
Date: Thu, 18 Sep 2003 16:23:50 +0200
Subject: Re: [PATCH] for PR12223
References: <20030913220849.GA29824@atrey.karlin.mff.cuni.cz> <wvld6dz2ryq.fsf@prospero.boston.redhat.com>

Hello,

> On Sun, 14 Sep 2003 00:08:49 +0200, Zdenek Dvorak <rakdver@atrey.karlin.mff.cuni.cz> wrote:
> 
> > 	* cp/typeck.c (build_modify_expr): Unshare lhs in set from
> > 	COND_EXPR.
> 
> Mark fixed this on the trunk by just removing the hunk of code you
> modified:
> 
> 2003-07-09  Mark Mitchell  <mark@codesourcery.com>
> 
>         * cp-tree.h (break_out_calls): Remove declaration.
>         * tree.c (break_out_calls): Remove.
>         * typeck.c (build_modify_expr): Avoid invalid sharing of trees.
> 
> Do you see any reason that shouldn't go onto the 3.3 branch as well?

I don't know of any such reason; IMHO it makes more sense the Mark's
way, I just did not want to remove the code I don't understand.

Zdenek

References:
- [PATCH] for PR12223
  - From: Zdenek Dvorak
- Re: [PATCH] for PR12223
  - From: Jason Merrill

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]