This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Fix for PR java/9577: Name Mangling Error


Andrew Haley wrote:
> Tom Tromey writes:
>  > >>>>> "Ranjit" == Ranjit Mathew <rmathew@hotmail.com> writes:
>  > 
>  > >> Please include a patch that creates a libgcj testcase.  Yes, I know
>  > >> most of the code is in the Bugzilla, so it should be easy.  We need
>  > >> this sort of thing as a regression test.
>  > 
>  > Ranjit> [See Attached Patch]
>  > 
>  > The test case is fine.  It would be best to check it in at the same
>  > time as the fix (if/when Andrew ok's it).
> 
> I'm happy with the patch if it fixes the test case.  However, I'm in
> no position to test it and check it in at the moment, and Ranjit
> doesn't have commit access.

I'm sorry for not mentioning this - I was very sleepy by
the time I was through with all the tests and came around
to submitting this.

In short, I tested the "before" and "after" scenarios
with last Thursday's 3.4 snapshot - the test fails to
link without the patch and PASSes after the patch is
applied. The patch still applies cleanly to the tree.

All testing was done on a native bootstrap build on
i686-pc-linux-gnu.

BTW, a big THANK YOU to every one who has put in the
the test harness - I just had to follow the naming
conventions and everything just worked without me
having to muck around with ".exp" files or having to
learn Tcl!

Ranjit.

-- 
Ranjit Mathew          Email: rmathew AT hotmail DOT com

Bangalore, INDIA.      Web: http://ranjitmathew.tripod.com/


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]