This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Patch to add builtin log2, log10, exp2, exp10/pow10optimizations

On Tue, 2003-09-09 at 15:22, Kaveh R. Ghazi wrote:
> Sorry, I don't see it.  There are two cases where I test value ==
> &dconste without initializing, but that's testing the address of
> dconste.

Good point.  That is safe though non-obvious, since dconste must have
been initialized by the caller in those cases.

>  If it's okay with you I'd like to submit a
> patch to initialize it with the others (like dconst0, etc) and remove
> all the checks for initialization.

Seems reasonable.

> Thanks, here's what I installed.  Let me know if the comments I added
> in the log*(func()) section are sufficient per your request.

Yes, it looks good.
-- 
Jim Wilson, GNU Tools Support, http://www.SpecifixInc.com
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]