This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [C++ PATCH]: Fix 11595


On 06 Sep 2003 17:27:42 +0200, Gabriel Dos Reis <gdr@integrable-solutions.net> wrote:

> Jason Merrill <jason@redhat.com> writes:
>
> | The use of POP_TIMEVAR_AND_RETURN seems unnecessary here.  In fact, it's
> | not clear to me why it would ever be useful to combine the two operations.
> | Gaby?
>
> It is an automated way to ensure that functions with multiple
> return-statements consistently pop the timevar stack in the return
> statements. 

But it's not automated--it requires that you repeat it for each return,
which seems no less complicated than repeating a normal pop at each return,
though I suppose the use of a long, capitalized macro name makes it stand
out more.

Steven:  Either way is fine.

Jason


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]