This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: *ping* [PATCH] unit-at-a-time for java
- From: Andrew Haley <aph at redhat dot com>
- To: Jeff Sturm <jsturm at one-point dot com>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Wed, 3 Sep 2003 11:19:55 +0100
- Subject: Re: *ping* [PATCH] unit-at-a-time for java
- References: <16170.16681.653808.479497@cuddles.cambridge.redhat.com><Pine.LNX.4.44.0309030207200.12689-100000@ops2.one-point.com>
Jeff Sturm writes:
> On Fri, 1 Aug 2003, Andrew Haley wrote:
> > Jeff Sturm writes:
> > > Richard has already approved the cgraphunit hunks.
> > >
> > > http://gcc.gnu.org/ml/gcc-patches/2003-07/msg02158.html
> >
> > This is OK if you have no libgcj testsuite regressions at -O3.
>
> I've taken another look at this. The present state of libgcj on mainline
> is that it doesn't build with GCJFLAGS="-O3 -g" and has one testsuite
> failure at -O3.
>
> The following patch (together with
> http://gcc.gnu.org/ml/gcc-patches/2003-09/msg00082.html) corrects both and
> enables unit-at-a-time for gcj. It avoids the problem I reported earlier
> (ICE in dwarf2out.c) by defining a start_inlining hook that cancels
> inlining if the function is not yet expanded.
Eeeeh. So we only inline in order? Nasty. Still, I guess it's the
best we can do at the present time.
> Tested on i686-pc-linux-gnu. OK for mainline?
OK. Thanks.
Andrew.