This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Patch installed to fix bug in top level configure argument processing
- From: "Kaveh R. Ghazi" <ghazi at caip dot rutgers dot edu>
- To: gcc-patches at gcc dot gnu dot org
- Cc: dj at redhat dot com, geoffk at apple dot com
- Date: Tue, 2 Sep 2003 09:59:19 -0400 (EDT)
- Subject: Patch installed to fix bug in top level configure argument processing
I tracked down the cause of the bug I reported here where flags to the
top level configure didn't work:
http://gcc.gnu.org/ml/gcc/2003-08/msg01745.html
The problem arose from a patch installed by Geoff on Aug 21.
Basically, with solaris2 /usr/ucb/sed, it doesn't like the lack of
space between the -f and the next argument. It works with /bin/sed
and GNU sed. (I happened to have /usr/ucb in my path first.) It
certainly could be argued that this is a ucb sed bug and one shouldn't
use ucb sed, nevertheless it hosed configure's argument processing and
the fix is simple.
I tested the patch by running configure in a clean tree with GNU sed,
saved the builddir, then patched the tree and reran configure with
/usr/ucb/sed, and ensured that the saved builddir contents matched the
current builddir. This ensures that the generated config.status et al
were identical. I also bootstrapped with --enable-languages=c and
checked that only C was built to ensure the original problem I
reported was fixed.
Installed as "obvious".
2003-09-02 Kaveh R. Ghazi <ghazi@caip.rutgers.edu>
* configure.in: Ensure arguments to sed are properly spaced.
* configure: Regenerate.
diff -rup orig/egcc-CVS20030901/configure.in egcc-CVS20030901/configure.in
--- orig/egcc-CVS20030901/configure.in 2003-08-27 20:01:16.000000000 -0400
+++ egcc-CVS20030901/configure.in 2003-09-02 09:23:32.976068426 -0400
@@ -76,7 +76,7 @@ EOF_SED
tmp="'$progname'"
for ac_arg
do
- tmp="$tmp '"`echo "$ac_arg" | sed -fconftestsed`
+ tmp="$tmp '"`echo "$ac_arg" | sed -f conftestsed`
done
rm -f conftestsed
TOPLEVEL_CONFIGURE_ARGUMENTS="$tmp"
@@ -1783,7 +1783,7 @@ s/ [[^' -][^ ]*] / /
s/^ *//;s/ *$//
s,\\,\\\\,g; s,\$,$$,g
EOF_SED
-baseargs=`echo " ${ac_configure_args} " | sed -fconftestsed`
+baseargs=`echo " ${ac_configure_args} " | sed -f conftestsed`
rm -f conftestsed
# For the build-side libraries, we just need to pretend we're native,