This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: PATCH handle null cpplib buffer
- From: Neil Booth <neil at daikokuya dot co dot uk>
- To: Per Bothner <per at bothner dot com>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Fri, 29 Aug 2003 08:51:46 +0100
- Subject: Re: PATCH handle null cpplib buffer
- References: <3F4EA9DD.3020502@bothner.com>
Per Bothner wrote:-
> I checked the attched patch into the trunk. It fixes a regression
> I introduced with my 08-21 patch. I'm not too happy with this patch,
> as it adds some extra tests in frequently-executed code. I tried
> moving the need_line field to cpp_reader (instead of cpp_buffer),
> which would actually be more efficient than the code it replaces,
> but restoring it on a pop_buffer is tricky. I'm going to see if I
> can get that idea to work over the weekend (while I'll be off-line).
No, it's fundamentally a property of the buffer.
Can't we revert your 08-21 rather than introduce this? I'm not
convinced from your 08-21 description that it was correct. I'm
concerned that this code might become something that only works
some of the time, and untangling it will be very hard.
Neil.