Re: PATCH: Use GNU Makeisms to simplify libgcc build

[Alexandre Oliva <aoliva at redhat dot com>]

On Aug 26, 2003, Mark Mitchell <mark@codesourcery.com> wrote:

> I've attached a ceremonial first patch using GNU make features.

I'm strongly inclined to request the reversal of this patch.  It's an
absolutely gratuitous reason to require GNU make.  We have most of the
infrastructure in place to not need GNU make's export feature, so I'd
much rather have a fix for the case in which {AR,RANLIB,NM}_FOR_TARGET
were passed down incorrectly.  I'm told the SC has approved the
requirement of GNU make, but I'm not happy with our doing so without a
very good reason, and this is definitely not it.

> Ideally, now that we are requiring GNU make, libgcc.mk would just be
> "include"d in the Makefile

include doesn't require GNU make.  BSD make and several other makes
support include just as well as GNU make, even with the same syntax.
Also, there are several ways to obtain include-equivalent semantics
that don't require the use of a make program that actually supports
include.

-- 
Alexandre Oliva   Enjoy Guarana', see http://www.ic.unicamp.br/~oliva/
Red Hat GCC Developer                 aoliva@{redhat.com, gcc.gnu.org}
CS PhD student at IC-Unicamp        oliva@{lsd.ic.unicamp.br, gnu.org}
Free Software Evangelist                Professional serial bug killer