This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Unreviewed math builtins patch (3x)
> From: Jim Wilson <wilson@tuliptree.org>
>
> > Patch for math builtins (taking pointer arguments)
> > http://gcc.gnu.org/ml/gcc-patches/2003-08/msg00449.html
>
> sin and cos are defined with ATTR_MATHFN_FPROUNDING, but sincos isn't,
> which doesn't seem right.
>
> Otherwise this looks OK.
The reason I treated sincos different from sin and cos is that sincos
writes into the memory referenced by it's pointer parameters. Indeed
all of the builtins added by this patch write into pointers. My
understanding is that this means they aren't "const" or "pure"
functions, so I checked in the patch as-is. If I've goofed let me
know and I'll fix the attrs however you feel is appropriate (just let
me know which attr is correct.)
Thanks,
--Kaveh
--
Kaveh R. Ghazi ghazi@caip.rutgers.edu