This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFC] patch: libffi dejanu test framework


Andreas Tobler <toa@pop.agri.ch> writes:

> Zack Weinberg wrote:
>
>> Yes, I think that's a good idea.  Our coding style prefers not to
>> have
>> a column of asterisks, but this is a minor detail.
>> It is probably unnecessary to name the file in the header.
>
> Ok, like this?
>
> /* Area:	ffi_call, closure_call
>     Purpose:	Check structure passing with different structure size.
> 		Contains structs as parameter of the struct itself.
>     Limitations:	none.
>     PR:		none.
>     Originator:	<andreast.at.gcc.gnu.org> 20030828  */

Yes.  The only other changes I would suggest are, get rid of the extra
indent on lines 2 through n so everything lines up nicely, and don't
munge the email addresses.

zw


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]