This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Unreviewed math builtins patch (3x)
- From: Harti Brandt <brandt at fokus dot fraunhofer dot de>
- To: Jim Wilson <wilson at tuliptree dot org>
- Cc: "Kaveh R. Ghazi" <ghazi at caip dot rutgers dot edu>, gcc-patches at gcc dot gnu dot org
- Date: Thu, 28 Aug 2003 12:07:32 +0200 (CEST)
- Subject: Re: Unreviewed math builtins patch (3x)
- References: <200308260423.AAA28662@caip.rutgers.edu> <3F4D6F3B.6060004@tuliptree.org>
On Wed, 27 Aug 2003, Jim Wilson wrote:
JW>Kaveh R. Ghazi wrote:
JW>> Patch for gamma, bessel and error function math builtins
JW>> http://gcc.gnu.org/ml/gcc-patches/2003-08/msg00398.html
JW>
JW>Ah. This adds some of the functions I noticed were missing. The
JW>complex arithmetic ones are still missing though.
JW>
JW>I have some of the same reservations I have with the last patch. Do we
JW>really want to give warnings by default for any program that uses
JW>function names like j0 and y0?
No. It is annoying enough that warnings are given for names like exp and
sin. These names should be reserved (and warned about) only if the
appropriate header file is included.
JW>You have erf{,f,l} as ATTR_MATHFN_FPROUNDING_ERRNO, but the description
JW>doesn't say anything about domain errors.
JW>
JW>The man page for gamma discourages use of it. Do we really want to
JW>implement it?
JW>
JW>No man page for significand, but I found it in the info documentation.
JW>Now that I thought to check the docs, I found pow10 and exp10 info.
JW>
JW>Otherwise this looks OK.
JW>
JW>> Patch for math builtins (taking pointer arguments)
JW>> http://gcc.gnu.org/ml/gcc-patches/2003-08/msg00449.html
JW>
JW>Same reservations.
JW>
JW>sin and cos are defined with ATTR_MATHFN_FPROUNDING, but sincos isn't,
JW>which doesn't seem right.
JW>
JW>Otherwise this looks OK.
JW>
--
harti brandt,
http://www.fokus.fraunhofer.de/research/cc/cats/employees/hartmut.brandt/private
brandt@fokus.fraunhofer.de, harti@freebsd.org