This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [patch] convert some call ABI macros to hooks, apply to sh, add bitfield swapper
On Aug 26, 2003, DJ Delorie <dj@redhat.com> wrote:
> Here is a diff between a mechananical change and the final result
Thank you *very* much for this.
> ! if ((mode) == DFmode
> ! && ROUND_REG (*ca, DFmode) != ROUND_REG (*ca, SFmode))
> ! {
> ! (*ca).free_single_fp_reg = (ROUND_REG (*ca, SFmode)
> ! + BASE_ARG_REG (mode));
> ! }
I'd appreciate a comment before this if to explain why you're testing
for DFmode. I got the impression it was a typo for quite some time
before understanding what was going on. I also get the impression
that it's missing handling of complex modes, but I don't quite
remember how these are handled. Maybe it would be best to test for
a mode other than SFmode of float MODE_CLASS instead?
The SH-specific changes are ok, thanks,
--
Alexandre Oliva Enjoy Guarana', see http://www.ic.unicamp.br/~oliva/
Red Hat GCC Developer aoliva@{redhat.com, gcc.gnu.org}
CS PhD student at IC-Unicamp oliva@{lsd.ic.unicamp.br, gnu.org}
Free Software Evangelist Professional serial bug killer