This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [tree-ssa] Lowering of VLA's, part 2
- From: law at redhat dot com
- To: Zdenek Dvorak <rakdver at atrey dot karlin dot mff dot cuni dot cz>
- Cc: Jason Merrill <jason at redhat dot com>, gcc-patches at gcc dot gnu dot org
- Date: Wed, 27 Aug 2003 13:04:23 -0600
- Subject: Re: [tree-ssa] Lowering of VLA's, part 2
- Reply-to: law at redhat dot com
In message <20030827181455.GA932@atrey.karlin.mff.cuni.cz>, Zdenek Dvorak write
s:
>Hello,
>
>> > * gimplify.c (struct tree_p_list): New type.
>> > (join_tree_p_list, add_tree_p_list, free_tree_p_list,
>> > build_stack_save_restore, prepend_to_exit_gotos): New functions.
>>
>> Use a TRY_FINALLY_EXPR instead.
>
>unnecesarily creating new eh handling constructs (that we really do not
>manage somehow greatly) seems a bit like overkill to me.
Normally I would agree, but TRY_FINALLY_EXPR expresses precisely what needs
to happen. Namely that the VLA has a scope and certain actions need to be
performed as that scope is exited.
And I wouldn't necessarily say our handling of TRY_FINALLY_EXPR is poor,
could it be improved? Most certainly, but then again, just about everything
can always be improved.
Jeff