This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [tree-ssa] Lowering of VLA's, second attempt

Hello,

> OK.  I might also add an
> 
> #ifdef ENABLE_CHECKING
> if (TREE_STATIC (var))
>   abort ();
> #endif
> 
> to make sure that we don't try to do this for local statics.

Added.  Just OOC -- why the ENABLE_CHECKING? It would make sense if the
check would be expensive, but otherwise it seems preferable to me to
detect such errors even if not checking (imho it is better if compiler
crashes than if it misscompiles something).

Zdenek
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]