This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Unreviewed^2 patches - bootstrap failure
- From: "Zack Weinberg" <zack at codesourcery dot com>
- To: "Ulrich Weigand" <weigand at i1 dot informatik dot uni-erlangen dot de>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Mon, 25 Aug 2003 12:36:49 -0700
- Subject: Re: Unreviewed^2 patches - bootstrap failure
- References: <200308171557.h7HFv0410808@faui1g.informatik.uni-erlangen.de>
"Ulrich Weigand" <weigand@i1.informatik.uni-erlangen.de> writes:
> Hello,
>
> the following patch fixing a bootstrap failure on s390 has
> been unreviewed for some time; likewise the others.
>
> [PATCH] Fix RTL-sharing bug in combine - bootstrap failure
> http://gcc.gnu.org/ml/gcc-patches/2003-07/msg01672.html
This is OK for mainline provided that you add a comment explaining
that true_rtx and false_rtx come from if_then_else_cond and therefore
may be shared with something that should not be modified.
I don't think it should be applied for 3.3 as long as this is merely a
latent problem, but feel free to convince Mark otherwise.
> [PATCH] Fix ICE when profiling on s390
> http://gcc.gnu.org/ml/gcc-patches/2003-07/msg01705.html
This is OK for both mainline and 3.3 (since this does fix an actual,
non-latent regression relative to 3.0).
> [PATCH] Simplify more non-paradoxical subregs in simplify_comparison
> http://gcc.gnu.org/ml/gcc-patches/2003-07/msg02247.html
It is not clear to me why the change in this patch enables the
optimization only for non-paradoxical subregs. Could you please
clarify?
zw