This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [m68k] Remove dead code


On Friday 22 August 2003 19:12, Zack Weinberg wrote:

> > Oops, I didn't notice. But it can't possibly work because the function
> > is static and unused in m68k.c, not even through the
> > TARGET_ASM_NAMED_SECTION macro.
> >
> > Now that you told me, I noticed that TARGET_ASM_NAMED_SECTION is also
> > defined in several places only used as a boolean flag:
>
> Careful when you say that...
>
> > ./gcc/target-def.h:#define TARGET_ASM_NAMED_SECTION
> > default_no_named_section ./gcc/target-def.h:                    
> > TARGET_ASM_NAMED_SECTION,
>
> this bit puts the value of TARGET_ASM_NAMED_SECTION into
> TARGET_INITIALIZER, which will be used (in m68k.c, which is why the
> function is static) to initialize the targetm structure.  Other code
> calls (*targetm.asm_out.named_section) (...);  (old fashioned notation
> used for clarity)

Then I need to put it back. I don't want to just back-out my previous
patch because the unused static function m68k_coff_asm_named_section()
causes a warning on m68k.c.

How could I tell whether coff.h has been included? There seems to be
no defines I can pick...

-- 
  // Bernardo Innocenti - Develer S.r.l., R&D dept.
\X/  http://www.develer.com/

Please don't send Word attachments - http://www.gnu.org/philosophy/no-word-attachments.html



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]