This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] powerpc64-linux bi-arch support
- From: David Edelsohn <dje at watson dot ibm dot com>
- To: Jakub Jelinek <jakub at redhat dot com>, Alan Modra <amodra at bigpond dot net dot au>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Tue, 19 Aug 2003 16:07:39 -0400
- Subject: Re: [PATCH] powerpc64-linux bi-arch support
- References: <20030527115337.GF24872@sunsite.ms.mff.cuni.cz>
A colleague of mine has noticed a problem with the ppc64 bi-arch
patch when linux64.h is configured without bi-arch. linux64.h includes
code to assign to DEFAULT_ABI, but that macro may be a constant:
#ifndef RS6000_BI_ARCH
#undef DEFAULT_ABI
#define DEFAULT_ABI ABI_AIX
...
#undef SUBSUBTARGET_OVERRIDE_OPTIONS
#define SUBSUBTARGET_OVERRIDE_OPTIONS \
do \
{ \
if (TARGET_64BIT) \
{ \
if (DEFAULT_ABI != ABI_AIX) \
{ \
DEFAULT_ABI = ABI_AIX; \
error (INVALID_64BIT, "call"); \
}
The assignment never will be executed because DEFAULT_ABI already is
ABI_AIX, but GCC correctly complains about an invalid lvalue.
Thanks, David