This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Simplify handling of TARGET_4300_MUL_FIX


Eric Christopher <echristo@redhat.com> writes:
> > 
> > Actually, when I said "see the default definition of the length attribute",
> > I was talking this in mips.md:
> > 
> >     (define_attr "length" ""
> >        (cond [...
> >               (and (eq_attr "type" "idiv")
> >                    (ne (symbol_ref "TARGET_CHECK_ZERO_DIV") (const_int 0)))
> >               (cond [(ne (symbol_ref "TARGET_MIPS16") (const_int 0))
> >                      (const_int 12)]
> >                     (const_int 16))
> >               ...
> > 	     ] (const_int 4)))
> 
> Enh, probably clearer (I'd not look in the default length for this sort
> of thing..) to explicitly list it in the insn pattern.

Well... there's only two places to look ;), the insn pattern itself or
the default definition.  And if the insn pattern doesn't have an explicit
length, you know you have to look at the default definition.

IMO, there's not really any difference between doing this for idiv and
doing it for loads and stores.

Richard


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]