This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Fix preprocessor/11839


Geoff Keating wrote:-

> Neil Booth <neil@daikokuya.co.uk> writes:
> 
> > My cppfiles.c rewrite fixed the case where a file was unreadable
> > (we wouldn't complain, and continue searching) but missed the
> > case where a path component is a file.  I tried to create a
> > testcase for this, and failed.
> 
> It's unrelated to this patch, but have you considered instead having
> an immediate error for the case where a file is unreadable?  Normally
> that is due to a broken build environment.  You usually don't want the
> compiler going on and perhaps finding another file of that name
> somewhere else.

That's what my paragraph above attempted to explain.  We *wouldn't*
complain and continue searching.  Now we stop and complain (try it!).
It was fixing this that introduced this regression.

Neil.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]