This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [Patch] Raise the dead: i860


On Sat, 9 Aug 2003, Jason Eckhardt wrote:

> This patch un-purges the i860 port.  The "new" config/i860/* files
> are mostly unchanged from the final pre-purge versions, and obviously
> won't build (pre-targetm port, poisoned macros, etc.).  Follow-up
> patches will resolve the build problems.

I believe that if a target is restored it needs to follow the requirements
for new targets (described in sourcebuild.texi) fully - for example,
although the target options supported by the i860 port weren't documented
before it was removed (bug 5362, still open for some other targets), it
must not be added back without full documentation.

I'd rather see a patch that makes the target work and conform to the
requirements of new targets (and cleanups such as not referring to "GNU
CC", not using PARAMS or old-style function definitions), that for
existing files is against current CVS versions; for files that were
removed is against the last version before they were removed; and for any
new files gives the contents of the new file.  I don't think adding a
nonworking target is a good idea; when it is added it should be in such a
state that reasonable testresults for the target (at least for C if not
other languages) can be sent to gcc-testresults.

> 	* config/i860/varargs.asm: New.

This file was added in revision 1.2, "preserve i860 __builtin_saveregs for
future reference"
<http://gcc.gnu.org/ml/gcc-patches/2001-04/msg01121.html>.  Could you fix
the i860 varargs support rather than re-adding that file, which is in CVS
if wanted for reference?

(The current system for implementing varargs *still* hasn't been
documented (bug 3386; the current system was added by RTH).  It's also
quite possible that remnants of the obsolete documented system remain but
can be removed from the compiler.)

> 	* config/i860/xm-i860.h: New.

This file was removed in a previous cleanup of Zack's some time before the 
target was removed, and should not need to be added back.

-- 
Joseph S. Myers
jsm@polyomino.org.uk


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]