This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Fix target/11699
- From: Richard Sandiford <rsandifo at redhat dot com>
- To: gcc-patches at gcc dot gnu dot org
- Cc: echristo at redhat dot com
- Date: 08 Aug 2003 16:27:56 +0100
- Subject: Fix target/11699
The mips port wasn't rejecting -mabi=eabi -mabicalls, which as far as
I know is an invalid combination. Trying to use it led to an ICE.
Patch tested on mips-sgi-irix6o32 and mipsisa64-elf. OK to install?
Richard
PR target/11699
* config/mips/mips.c (override_options): Reject -mabi=eabi -mabicalls.
Index: config/mips/mips.c
===================================================================
RCS file: /cvs/gcc/gcc/gcc/config/mips/mips.c,v
retrieving revision 1.295
diff -c -d -p -F^\([(a-zA-Z0-9_]\|#define\) -r1.295 mips.c
*** config/mips/mips.c 4 Aug 2003 20:23:15 -0000 1.295
--- config/mips/mips.c 8 Aug 2003 15:13:22 -0000
*************** override_options ()
*** 5037,5042 ****
--- 5037,5049 ----
if (TARGET_BRANCHLIKELY && !ISA_HAS_BRANCHLIKELY)
warning ("generation of Branch Likely instructions enabled, but not supported by architecture");
+ /* The effect of -mabicalls isn't defined for the EABI. */
+ if (mips_abi == ABI_EABI && TARGET_ABICALLS)
+ {
+ error ("unsupported combination: %s", "-mabicalls -mabi=eabi");
+ target_flags &= ~MASK_ABICALLS;
+ }
+
/* -fpic (-KPIC) is the default when TARGET_ABICALLS is defined. We need
to set flag_pic so that the LEGITIMATE_PIC_OPERAND_P macro will work. */
/* ??? -non_shared turns off pic code generation, but this is not