This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Speed-up get_identifier("main") (take 2)

From: Richard Henderson <rth at redhat dot com>
To: Jakub Jelinek <jakub at redhat dot com>
Cc: Roger Sayle <roger at eyesopen dot com>, Zack Weinberg <zack at codesourcery dot com>, gcc-patches at gcc dot gnu dot org
Date: Thu, 7 Aug 2003 17:19:35 -0700
Subject: Re: [PATCH] Speed-up get_identifier("main") (take 2)
References: <87k79qmnyk.fsf@codesourcery.com> <Pine.LNX.4.44.0308070720500.5973-100000@www.eyesopen.com> <20030807095326.X23055@devserv.devel.redhat.com>

On Thu, Aug 07, 2003 at 09:53:26AM -0400, Jakub Jelinek wrote:
> #if GCC_VERSION >= 3000
> # define get_identifier(str) \
>   (__builtin_constant_p (str)						\
>    ? get_identifier_with_length ((str), (unsigned) strlen (str))	\
>    : get_identifier (str))
> #endif

Additionally, the cast to unsigned is not good.  We should make
the argument to get_identifier_with_length be size_t.


r~

Follow-Ups:
- Re: [PATCH] Speed-up get_identifier("main") (take 2)
  - From: Zack Weinberg
- [PATCH] Speed-up get_identifier("main") (take 4)
  - From: Roger Sayle

References:
- Re: [PATCH] Speed-up get_identifier("main")
  - From: Zack Weinberg
- [PATCH] Speed-up get_identifier("main") (take 2)
  - From: Roger Sayle
- Re: [PATCH] Speed-up get_identifier("main") (take 2)
  - From: Jakub Jelinek

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]