This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: PATCH to split up cpp_read_main_file
- From: Per Bothner <per at bothner dot com>
- To: Geoff Keating <geoffk at geoffk dot org>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Tue, 05 Aug 2003 21:06:24 -0700
- Subject: Re: PATCH to split up cpp_read_main_file
- References: <3F2FE7F0.30603@bothner.com> <jmn0eovv8g.fsf@desire.geoffk.org>
Geoff Keating wrote:
You did check that intermodule analysis still works (GCC bootstraps
with --enable-intermodule) after your patch, right?
I did not, since I didn't even know of the existence of the
--enable-intermodule configure flag. When I asked you about
testing so it didn't break your changes, you just mentioned
compiling a trivial pair of files, and if you mentioned the
--enable-intermodule flag then I forgot about it.
Generally, I don't think you can expect people to routinely test
with special configure flags. Features that are only enabled
by special configure flags aren't fundamentally different from
features that are in separate development branches - except that
hopefully it will be easier to keep them in synch. The most you
can reasonbly expect is that if someone breaks a non-default
feature is that they try to fix it, but (just as with target-specific
breakage) it's up to you to test it.
--
--Per Bothner
per@bothner.com http://per.bothner.com/