This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Framework support for darwin
- From: Geoff Keating <geoffk at geoffk dot org>
- To: Mike Stump <mrs at apple dot com>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: 05 Aug 2003 00:25:23 -0700
- Subject: Re: Framework support for darwin
- References: <D00CB7DA-C6FE-11D7-A9D4-003065A77310@apple.com>
Issues that made it hard for me to understand this patch:
- You have defined
+ typedef const char *(*context_dependent_cb)(cpp_reader *, const char *, const\
char *);
but there doesn't seem to be any explanation of what it is supposed to
do, what its parameters are, or what it returns.
- You say "Search for HEADER in context dependent way" but you don't
explain what "context" might be.
- There are many style issues, I won't document them all here.
Suffice to say that the patch needs lots of cleaning up.
Things that I did understand, and didn't like:
- You seem to have implemented separate framework and regular
directory search paths. I believe we agreed that frameworks and
regular header search directories should be searched in the order
they appear on the command line, since this is most flexible and
existing implementations differ in their behaviour in this regard.
- This patch adds a lot of code to c-incpath.c. Couldn't it be moved
into darwin.c?
--
- Geoffrey Keating <geoffk@geoffk.org>