This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Patch to categorize builtins.def


 > From: "Zack Weinberg" <zack@codesourcery.com>
 > 
 > "Kaveh R. Ghazi" <ghazi@caip.rutgers.edu> writes:
 > 
 > > In working on builtins.def, it's much easier for me to work on
 > > conceptual classes of builtins.  So this patch breaks the builtins
 > > list into groups.
 > 
 > Um.  Didn't you argue for not having any groupings just this morning?
 > zw

Seems like an eternity...

I'm not against groupings per se.  I just noted that we didn't do it
at the time and that was in support of sorting atan2 alphabetically in
between atan and atanf.  I.e. not having scattered one-off exceptions
to an automated sort.  Perhaps I'm contradicting myself, can I change
my mind? :-)

Regarding categories, what I'm finding is that when I want to
e.g. work on a testcase for math builtins, it helps to be able to
quickly scan the list of just math builtins in one section rather than
read every single line in the file trying to pick out certain ones.

The categories are still sorted alphabetically within themselves.  And
you can still maintain it, just in categorical chunks.  The atan2
funcs still worm their way in between atan and atanf.

Ok?

		--Kaveh
--
Kaveh R. Ghazi			ghazi@caip.rutgers.edu


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]