This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [tree-ssa] Update loop analysis 1/2
- From: Diego Novillo <dnovillo at redhat dot com>
- To: Pop Sébastian <pop at gauvain dot u-strasbg dot fr>
- Cc: "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>
- Date: 31 Jul 2003 08:15:06 -0400
- Subject: Re: [tree-ssa] Update loop analysis 1/2
- Organization: Red Hat Canada
- References: <20030730221945.GC10639@gauvain.u-strasbg.fr>
On Wed, 2003-07-30 at 18:19, Pop Sébastian wrote:
> * basic-block.c (basic_block_def): Add num_latches.
> * cfg.c (entry_exit_blocks): Initialize num_latches to 0 for
> entry and exit blocks.
> * cfghooks.h (HEADER_BLOCK): Use the num_latches field.
> * cfgloop.c (canonicalize_loop_headers): Remove the initializations
> and finalization of basic_block.aux fields.
> * cfgrtl.c (rtl_make_forwarder_block,
> redirect_edge_with_latch_update): Remove an allocation of
> basic_block.aux field.
> * loop-init.c (loop_optimizer_init, loop_optimizer_finalize):
> Conditionally execute the cfg_layout specific parts only when
> cfg_level is AT_RTL_LEVEL.
> (loop_optimizer_finalize): Return if loops is a NULL pointer.
>
This is OK. Thanks.
Since you're cleaning up the CFG code, could you remove the AT_..._LEVEL
enums and replace them with cfghooks? I think it will be cleaner in the
long run.
It will also minimize merge conflicts. All the CFG hooks for trees
should go to tree-cfg.c.
Thanks. Diego.